Zac Burns

Results 65 comments of Zac Burns
trafficstars

@lutter > I just looked at the `StableHash` docs, and can't quite figure out the right way to do this with its API. Could you comment here how we could...

@lutter @kamilkisiela It's difficult to reconcile these two: [Use stable hash to avoid cloning](https://github.com/graphprotocol/graph-node/pull/3840#issuecomment-1217114489) [Level 2 hash required for security](https://github.com/graphprotocol/graph-node/pull/3840#discussion_r947222988) `stable-hash` gives you a choice of either a Level 1...

@lutter @kamilkisiela For a Level 2 hash function, I'd recommend this one: [XXH3 128 with secret](https://docs.rs/xxhash-rust/0.8.5/xxhash_rust/xxh3/fn.xxh3_128_with_secret.html) using a 192 byte secret initialized as a `lazy_static`. It operates at RAM speeds...

@kamilkisiela > I tried to use `second-stack` but I'm not sure if I use it correctly. > It feels wrong to wrap everything with a `buffer`. I tried to return...

I would also like to get this stabilized and can present a use-case. I'm working on [firestorm](https://github.com/That3Percent/firestorm): a low overhead intrusive flame graph profiler. I created `firestorm` because existing solutions...

To elaborate here's code I would like to have be able to compile: ```rust #[macro_export] macro_rules! profile_method { ($($t:tt)*) => { let _firestorm_method_guard = { const FIRESTORM_STRUCT_NAME: &'static str =...

@oli-obk Yes, you are right. Both issues would need to be resolved to support my use-case in the way that I would like.

Yes, I'm coming around and think that the panic here is reasonable and desirable. I was originally thinking that at the very least the docs should be amended to document...

Thanks for the write-up, this is a clear explanation of a source of indexing-time determinism issues in graph-node. Initial thoughts: Yes, we can detect changes by hashing raw data from...

@lutter > I don't think that discrepancies between providers that do not lead to PoI differences are all that important This is an interesting point. Taking this idea to it's...