Thad House

Results 248 comments of Thad House

@microsoft-github-policy-service agree

> > ``` > > core.lib(library.obj) : error LNK2001: unresolved external symbol CxPlatWorkerPoolInit [D:\a\msquic\msquic\src\bin\winkernel\msquicpriv.kernel.vcxproj] > > core.lib(library.obj) : error LNK2001: unresolved external symbol CxPlatWorkerPoolUninit [D:\a\msquic\msquic\src\bin\winkernel\msquicpriv.kernel.vcxproj] > > ``` > >...

Ok. Should now correctly be fixed. Forgot how UNREFERENCED_PARAMETER macro worked.

Some of those are failing on main after #4518 was merged. But there are a few that look to be me.

Yeah this absolutely will not work. If you look at the c++ file deploy you’ll see we change the owner of the deployed file to lvuser. The same thing would...

This definitely won't work. getFiles() is a file tree, and toString() on that is definitely not correct.

So, in all likelyhood, the way a lot of this stuff works will likely be changing. There probably isn't a great need to keep this PR up to date, as...

No, Java does not work like that. When no references are left to the object container, it might get cleaned up sometime in the future by the garbage collector. But...

Honestly, until MSVC gets a /std:c++23 flag, this really can't be merged. We cannot ship libraries targeting /std:c++latest safely at all.

Is the plan that the RobotBase class managing these modes is single-threaded or multi-threaded? Definitely still single threaded, I don't expect that to change. Linear modes would still run in...