Thibaut Goetghebuer-Planchon

Results 97 comments of Thibaut Goetghebuer-Planchon

I modified a bit your PR to address some of my comments, mainly moving things to `sparse_growth_policy.h` to avoid a new file, renaming to `TSL_SH_*` prefix and adapting the test...

Closing, as out-of-date. Don't hesitate to reopen if it's a feature that is still needed.

Thank you, it looks good, I merged the change.

Sorry for the delay. I don't see an easy way to make it exception safe and I understand it can be a quite useful addition. Adding a warning in the...

Thanks, I merged it.

@alankelly Thanks, it seems the test with `bazel run //tensorflow/lite/testing:generate_examples -- --zip_to_output=batch_to_space_nd -- --output_path=test` is passing on my side. I tried to add the date range when creating the tensor...

@miaout17 As discussed, please see https://arxiv.org/abs/2007.13224 for a network using MaxPool3D and https://keras.io/examples/vision/3D_image_classification/ example that uses it. It'd be nice to be able to convert the Keras model described in...

Thank you for the review. Dusted off the PR a bit, fixed the merge conflicts and addressed the comments. Only some MLIR tests still need to be added which I...