Thibaut Goetghebuer-Planchon

Results 62 comments of Thibaut Goetghebuer-Planchon

Hi, Thanks for your PR. It would effectively be nice to support fno-exceptions, I didn't took the time to do it yet for this library. Could you check out how...

Thank you for the update. A few comments. * Could you use the `SH` (sparse hash) like `tsl_sh_assert` instead of `SM´? * > std::abort is used instead of std::terminate, because...

Hi, Thank you for your contribution. Would it be possible to change `__hash` to something like `hash_` as any name starting with two underscores are reserved? Thanks.

Thank you very much for your contribution. I have to dig more into it but I'm a bit wary of the size of the change and maintenance burden for something...

Hello, Compared to a `std::unordered_map` which stores `std::pair` the `tsl::ordered_map` has to store `std::pair` to be able to support move-only `Key`. As the `std::unordered_map` stores the pairs inside a node...

A custom pair would solve the range-based for-loop problem though it would not really be possible to expose a `.first` member. It'd break backward compatibility while still not being a...

Hi, From my understanding `absl::flat_hash_map` [uses](https://github.com/abseil/abseil-cpp/blob/1ae9b71c474628d60eb251a3f62967fe64151bb2/absl/container/internal/container_memory.h#L302) an union of `std::pair` and `std::pair` when `absl::container_internal::memory_internal::IsLayoutCompatible` value is true and takes advantage of: ``` // Accessing one of the union fields while...

Hi, Thank you for the report, it can be fixed. Currently the `rehash_impl` creates a new `sparse_hash` and move/copy the values from the old hash map to the new one...

Hi, Thank you for your contribution. Currently you're implementing the insert with the heterogeneous key only for `robin_set`, how do you plan to do it for `robin_map`? The current `insert`...

Hello, Thank you very much for the report. I effectively completely missed that when implementing the backward shift deletion. I started the implementation of a fix in the [fix_issue_20](https://github.com/Tessil/robin-map/compare/fix_issue_20) branch....