Thibaut Goetghebuer-Planchon
Thibaut Goetghebuer-Planchon
I just realised in the `base()` documentation that `The base iterator refers to the element that is next (from the std::reverse_iterator::iterator_type perspective) to the element the reverse_iterator is currently pointing...
Yes, at the time of creating the map, I used the default `std::hash` as I didn't wanted to maintain my own hash function or have the repository depends on an...
Hi, Thank you for the report and sorry for the delay. I created a PR to address the issue if you could take a look. It's similar to the SDL...
Casting `std::pair` to `std::pair` is not a defined behaviour https://stackoverflow.com/questions/14272141/is-casting-stdpairt1-t2-const-to-stdpairt1-const-t2-const-safe
Yes, that would be an useful fix. The lib was developed before C++17 `if constexpr` and I just used a simple `if` to avoid `std::enable_if` at the time. Could you...
Thank you for the contribution, unfortunately casting a `std::pair&` to a `std::pair&` is an undefined behaviour. See https://stackoverflow.com/questions/8305793/is-it-possible-to-cast-a-pairkey-value-to-a-pairconst-key-value for more information.
Thank you for the contribution, I'll try to take a look this weekend. I didn't know it'd be part of C++26, I'll check a bit the proposal.
Thanks for the contribution. The change looks good but I'm a bit worried about the backward compatibility and the risk of changing the performance of existing users. We're applying the...
Thanks for the report. There's effectively a limit of 65535 due to the `IndexSizeT` of uint16 used for the `array_hash` of the `htrie_hash`. I added a check in commit 611bdccbe40f4bfb7f75d849c5bec6a003695db8....
@gbaned Done, thanks.