Terry Howe

Results 342 comments of Terry Howe

So if changed is true, it must either hit: https://github.com/TerryHowe/ansible-modules-hashivault/blob/master/ansible/modules/hashivault/hashivault_oidc_auth_role.py#L194 or https://github.com/TerryHowe/ansible-modules-hashivault/blob/master/ansible/modules/hashivault/hashivault_oidc_auth_role.py#L198 and it should really be a matter of does this also do an update https://github.com/TerryHowe/ansible-modules-hashivault/blob/master/ansible/modules/hashivault/hashivault_oidc_auth_role.py#L203

I don't recall now if the change was in hvac or Hashicorp vault where this got changed from `policies` to `token_policies`. At this point, `policies` should be removed as a...

Similar to update, but as I recall update only changes values that are present in the request https://github.com/TerryHowe/ansible-modules-hashivault/blob/main/ansible/modules/hashivault/hashivault_write.py#L122

I'm not a lawyer, but from my observation, the author can hold a copyright on material licensed in an open source project and what matters is the license of the...

I'm don't think this module should validate the correctness of the request in this case. It should just make `allowed-redirect_uris` optional and let vault validate.

Definitely possible, personally, I'm tied up with other concerns though, so it would be a while until this came up as a priority.

Probably could use the generic secrets engine module, but I haven't tried it.

Yeh, once the backend is configured, the normal read and write operations should work fine `hashivault_secret` or `hashivault_write`.

There was a change to underlying software either hvac or Hashicorp Vault itself where token_policies is now the argument. The policies argument was left in for backward compatibility, it should...

Yeh, most likely very similar to group_filter https://github.com/TerryHowe/ansible-modules-hashivault/blob/main/ansible/modules/hashivault/hashivault_auth_ldap.py#L80