Thomas B
Thomas B
> We can't change the existing method > We should not have a std conversion that sets non blocking Since you all seem to agree on this and I'm not...
> when debug assertions are enabled Ah I missed "debug mode". That seems to solve most points indeed. > [Deprecating the current method] does not entirely solve the issue. We...
Plot twist: there is no `is_blocking`/`is_nonblocking` function on any of the corresponding `std` objects: https://doc.rust-lang.org/stable/std/net/index.html?search=blocking So I'm not sure how to detect whether they are configured as blocking. If that...
> You can query it using [socket2::SockRef::nonblocking](https://docs.rs/socket2/latest/socket2/struct.SockRef.html#method.nonblocking). Wonderful. That's done. I think I'm reasonably happy with the current state with regards to TcpListener. I'd like this one to be fully...
> What about `from_blocking_std` and `from_nonblocking_std` I agree it's much better than `from_blocking_std`/`from_std_unchecked`. However, although first point is less impactful because these would be homogeneous, I slightly prefer `assume/set` for...
> because `from_{blocking, nonblocking}_std` won't show up in searches for the string "from_std", while `from_std_{blocking, nonblocking}` do contain "from_std" as a substring. > for the reasons mentioned about specifically from_blocking_std...
> I probably prefer to leave the behavior of from_std unchanged Unchanged as in "as currently implemented in this PR" or as in "as currently implemented on master, but deprecated"?...
> As in, unchanged from master. So it looks like you disagree with Carl that consistency with the `TryFrom` impl wins. (https://github.com/tokio-rs/tokio/pull/5597#issuecomment-1499512782) I agree with you but I don't think...
> This issue with fixed is blocking use of AVRO on my side. If you only need deserialization ATM (because serialization it's not implemented yet in that rework), you may...
> I need both serialization and deserialization, using avro-datum (no embeded schemas) for complex multifile schemas (see the recently merged [AVRO-3683](https://issues.apache.org/jira/browse/AVRO-3683)). Also fixed length arrays, and multi-value nullable unions. If...