Thomas B

Results 275 comments of Thomas B
trafficstars

So re-defining the dsl module in the exact same way as within Diesel in the local crate works. (I did not expect name resolving would work differently on external modules...

Wait `not` and `exists` both work. Not sure yet what the difference with `min` is.

Ok so the issue comes from the fact that `sql_function!` generates a module with the same name as the function. When that happens, Rust gets confused with the import of...

The best compromise is probably to release a new `sql_function` macro that generates the helper type at that path instead of the module. This would also enable removing this doc:...

@weiznich I'd like an opinion on whether this particular breaking change could be considered a bug fix, vs the loss of ergonomics and duplicated types of pascal-casing

> We only talk about these 6 functions here, right? The issue is that we want the types to all be in the same case so that `dsl::auto_type` can look...

Cool, thanks. As far as I'm concerned I'd favor the compromise of considering the solution at https://github.com/diesel-rs/diesel/issues/3745#issuecomment-1678862830 as a bugfix of the types not being available in the `dsl` module,...

> Help for this classification would be greatly appreciated. I've implemented the fix for `sql_function` in the slightly-breaking manner in #3773, which should fix the issue with the sql functions....

This looks like an sqlite-specialized example. Do we have equivalents for the other backends? If that's the case we probably want to add this comment here as well no?

> We discussed the naming issue on discord For reference: https://discord.com/channels/500028886025895936/500336346770964480/1093193069408567386 ![image](https://user-images.githubusercontent.com/9094255/230158657-902cf46d-b8d6-45bd-81c7-dcd2399f2d26.png) ![image](https://user-images.githubusercontent.com/9094255/230158754-b30c239b-0ff6-41f1-9421-0e764234dc6b.png)