Artem Yakimenko

Some save() methods have arguments and shouldn't

1

File is probably fine but user/server should _not_ have them ``` λ grep -R 'def save([a-z ]' . ./lib/fog/google/models/sql/user.rb: def save(password: nil) ./lib/fog/storage/google_xml/models/file.rb: def save(options = {}) ./lib/fog/compute/google/models/server.rb: def save(username:...

Server.image_name should actually return a name, not a self-link

1

`image_name` should actually return a name, not a self-link https://github.com/fog/fog-google/blob/3741053202f7c856fbe9fa5ed715bd213f48e236/lib/fog/compute/google/models/server.rb#L182-L200

Requests should return `Fog::Compute::Google::Operation`

1

Currently requests return an API operation, i.e.: `Google::Apis::ComputeV1::Operation:` And then usually get parsed by model like so: ``` operation = Fog::Compute::Google::Operations.new(:service => service) .get(data.name) ``` That's a lot of duplicate...

Get rid of "name eq .*#{identity}" logic

3

So, if I'm reading it right the "name eq .*#{identity}" logic is not needed anymore. I'm talking about the "Servers" for example: https://github.com/fog/fog-google/blob/8780575ea089e75b8628565ec6f112e5e850b419/lib/fog/compute/google/models/servers.rb#L34-L38 I think we shouldn't append the `.*`...

TargetPool.get_health should return better output

1

Currently: ``` target_pool.get_health(server.name) => {"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"=> [{:health_state=>"UNHEALTHY", :instance=>"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"}]} ``` or without parameters ``` target_pool.get_health() => {"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"=> [{:health_state=>"UNHEALTHY", :instance=>"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"}], "https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-2-testtargetpools-test-get-health"=>[]} ``` Ideally this should just return state: - HEALTHY - UNHEALTHY -...

Add a `project` method to Images

6

See: ``` # This attribute is not available in the representation of an # 'image' returned by the GCE server (see GCE API). However, # images are a global resource...

Can log configuration be added to the chart?

2

Currently the chart doesn't allow operating the `--log ` flag which is important to us as we've been waiting for a long time for JSON logging and want to get...

Cannot generate Traefik CRD's in TypeScript

1

Here's the repro, lemme know if there's any additional info you need. VERSION: ``` λ crd2pulumi -v crd2pulumi version v1.0.5 ``` REPRO: ``` λ git clone https://github.com/traefik/traefik-helm-chart λ cd traefik-helm-chart/traefik/crds...

SSH never times out

3

Well this is embarassing, see `run_instance.rb`: ``` unless env[:terminated] env[:metrics]["instance_ssh_time"] = Util::Timer.time do # Wait for SSH to be ready. env[:ui].info(I18n.t("vagrant_google.waiting_for_ssh")) while true # If we're interrupted just back out...

See https://github.com/mitchellh/vagrant-google/issues/234#issuecomment-619969750 Scenario that should let us repro: ``` I had two projects A and B, I specified to use project B in this plugin but I used project A’s...