mistica-web icon indicating copy to clipboard operation
mistica-web copied to clipboard

feat(skin): rename some design tokens

Open marcoskolodny opened this issue 1 year ago • 4 comments

BREAKING CHANGE: some design tokens are renamed

Renamed tokens: https://github.com/Telefonica/mistica-design/pull/1869/

Issue: Link

marcoskolodny avatar Aug 21 '24 10:08 marcoskolodny

Size stats

master this branch diff
Total JS 12.2 MB 12.2 MB -280 B
JS without icons 2.03 MB 2.03 MB -280 B
Lib overhead 76.8 kB 76.7 kB -84 B
Lib overhead (gzip) 18.8 kB 18.8 kB +7 B

github-actions[bot] avatar Aug 21 '24 10:08 github-actions[bot]

Accessibility report ✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

github-actions[bot] avatar Aug 21 '24 10:08 github-actions[bot]

Deploy preview for mistica-web ready!

✅ Preview https://mistica-jydbg57z0-flows-projects-65bb050e.vercel.app

Built with commit 201cba7b92ac93773619e21ec941f10b52279327. This pull request is being automatically deployed with vercel-action

github-actions[bot] avatar Aug 21 '24 10:08 github-actions[bot]

Screenshot tests report

✔️ All passing

github-actions[bot] avatar Aug 21 '24 10:08 github-actions[bot]

I suggest to rename the pr title to "rename some internal design tokens" to be more clear about the impact of this change in release notes.

I know that these token can be used in any place, but should not be a common use

yceballost avatar Aug 26 '24 22:08 yceballost

I suggest to rename the pr title to "rename some internal design tokens" to be more clear about the impact of this change in release notes.

I know that these token can be used in any place, but should not be a common use

@yceballost I've modified the PR description with your suggestion (that message will be in the release notes)

marcoskolodny avatar Aug 27 '24 08:08 marcoskolodny

:tada: This PR is included in version 15.21.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tuentisre avatar Sep 12 '24 18:09 tuentisre