Omar Kamel

Results 206 comments of Omar Kamel

Be sure to take into account situations where part declarations can be configured to be _not_ right next to the source file through the build_runner configuration

not particularly hung up on the field name - just that we should get one. > Downloading the file then extracting it in your program will be a lot faster...

No, I mean that most sorting in the api is done via query parameters and done serverside. [this code](https://github.com/pterodactyl/panel/blob/develop/app/Http/Controllers/Api/Client/ClientController.php) would need to add sorting options to do this correctly. Notice...

No. As I said, sorting is supposed to be server-side. Refer to my previous comment

That's perfectly acceptable to me. If its possible to get it at all (and perhaps cache it somehow?) then it makes it possible to check if files are correct. additionally,...

That's true. I suppose that does make this unnecessary. Instead, could the remote download api include a hash in its response when a file is downloaded? I believe that would...

I have recently discovered a more direct use for a `get hash` endpoint. Turns out, Modrinth has an endpoint for finding the associated resource by file hashes! [versionsFromHashes](https://docs.modrinth.com/api-spec#tag/version-files/operation/versionsFromHashes) (accepts either...

Should i make a separate issue for a distinct hash endpoint or let it be this one?

> The complete lack of documentation about the panel and wings docker images makes it very difficult to set this up using docker. There is basically no information about which...