panel icon indicating copy to clipboard operation
panel copied to clipboard

Server Sorting: Sort servers from A-Z or Z-A.

Open nullure opened this issue 1 year ago • 10 comments

Be able to sort servers from A-Z or Z-A which makes navigating servers easier.

nullure avatar Dec 18 '23 13:12 nullure

IF this is a PR for the current releases then it is the wrong branch develop is v2, 1.0-develop are the current releases

QuintenQVD0 avatar Dec 18 '23 13:12 QuintenQVD0

~~There is already an open PR for this functionality: #3821 (which also adds more sorting modes)~~

Boy132 avatar Dec 18 '23 16:12 Boy132

There is already an open PR for this functionality: #3821 (which also adds more sorting modes)

That's what I wanted to say, but the PR is for sorting servers, not files

PadowYT2 avatar Dec 18 '23 19:12 PadowYT2

There is already an open PR for this functionality: #3821 (which also adds more sorting modes)

That's what I wanted to say, but the PR is for sorting servers, not files

Ah, that's my bad. Then nevermind my comment.

Boy132 avatar Dec 18 '23 19:12 Boy132

Isn't sorting server-side?

TekExplorer avatar Dec 18 '23 19:12 TekExplorer

Isn't sorting server-side?

There's no sorting in the server list. Well there is, just that it is hardcoded

PadowYT2 avatar Dec 18 '23 19:12 PadowYT2

Althougjh I don't really like to have this. The current order system will be just messed up

PadowYT2 avatar Dec 18 '23 19:12 PadowYT2

No, I mean that most sorting in the api is done via query parameters and done serverside. this code would need to add sorting options to do this correctly.

Notice here in the application side. This is how sorting is handled, and any pr that adds new sorting options should do the same, or else you will end up with local sorts, which will miss items on the next pages that should now be front and center.

TekExplorer avatar Dec 18 '23 20:12 TekExplorer

Is this mergable? Or it needs improvements

nullure avatar Dec 25 '23 10:12 nullure

No. As I said, sorting is supposed to be server-side. Refer to my previous comment

TekExplorer avatar Dec 25 '23 13:12 TekExplorer