panel
panel copied to clipboard
Server Sorting: Sort servers from A-Z or Z-A.
Be able to sort servers from A-Z or Z-A which makes navigating servers easier.
IF this is a PR for the current releases then it is the wrong branch develop is v2, 1.0-develop are the current releases
~~There is already an open PR for this functionality: #3821 (which also adds more sorting modes)~~
There is already an open PR for this functionality: #3821 (which also adds more sorting modes)
That's what I wanted to say, but the PR is for sorting servers, not files
There is already an open PR for this functionality: #3821 (which also adds more sorting modes)
That's what I wanted to say, but the PR is for sorting servers, not files
Ah, that's my bad. Then nevermind my comment.
Isn't sorting server-side?
Isn't sorting server-side?
There's no sorting in the server list. Well there is, just that it is hardcoded
Althougjh I don't really like to have this. The current order system will be just messed up
No, I mean that most sorting in the api is done via query parameters and done serverside. this code would need to add sorting options to do this correctly.
Notice here in the application side. This is how sorting is handled, and any pr that adds new sorting options should do the same, or else you will end up with local sorts, which will miss items on the next pages that should now be front and center.
Is this mergable? Or it needs improvements
No. As I said, sorting is supposed to be server-side. Refer to my previous comment