Tejas Kumar

Results 102 comments of Tejas Kumar

What about the `end` event? Sometimes people pipe errors there...

@JoshRosenstein, thanks for your amazing contributions! šŸŽ‰ How would Tooltip look with `useLayoutEffect`? I'm not really seeing the need for synchronicity there?

> As well I would throw ID fields into the discussion. Do we really need them in library? Can't they be crafted in user land instead? AFAIK, ID fields are...

I shall create an ESLint plugin for backstage since we'll have more needs arise eventually. Already started. Here's what I have so far: ![image](https://user-images.githubusercontent.com/9947422/118853655-454a3200-b8d4-11eb-8895-1395e4d3583d.png)

> Tbh the core/core-api import rule isn't too necessary as they're both likely to be deprecated and replaced soon. Oh, lol I wish I knew this earlier. I will try...

> Just remembered, could you add the adapter to these lists: > > For auto-labeling issues: https://github.com/nextauthjs/next-auth/blob/main/.github/issue-labeler.yml https://github.com/nextauthjs/next-auth/blame/main/.github/ISSUE_TEMPLATE/3_bug_adapter.yml#L23-L34 > > For auto-labeling PRs https://github.com/nextauthjs/next-auth/blob/main/.github/pr-labeler.yml Done in https://github.com/nextauthjs/next-auth/pull/4911/commits/352a40ed45dbc89efd7e51809418c6e9b5b40a30!

Okay! I've added tests and everything else required. This LGTM to me so far. Did I miss anything? 🤩

I’m noticing a couple of checks are still pending. Is this something I can fix? 🧐

@ThangHuuVu, @balazsorban44, done! šŸ™Œ

Wow, that's been open since 2021. 😨 I wonder which one we'll merge sooner. šŸ˜‹