operational-ui
operational-ui copied to clipboard
contiamo
Icon instance vs class in Input component.
At the moment, there are 2 Input props concerning icons: statusIcon and placeholderIcon.
statusIcon is passed in as an icon instance, so that the user has more control over styling. placeholderIcon is currently the same, for consistency within the component, but it would make more sense for its size, colour etc. to be fixed.
The proposal is to remove statusIcon entirely from Input (Input already has too many options, and the user could just position an icon next to the input) and change placeholderIcon to a React component (type: IconComponentType).
As well I would throw ID fields into the discussion. Do we really need them in library? Can't they be crafted in user land instead?
We're using it across the product in quite a few places. Might be nice to have it in the library then.
In that case maybe we could have ID fields as a separate component that extends Input, rather than having an isUniqueId prop on the Input component.
As well I would throw ID fields into the discussion. Do we really need them in library? Can't they be crafted in user land instead?
AFAIK, ID fields are optional props that are crafted in userland, but filled in for a11y if users omit them.
https://github.com/contiamo/operational-ui/blob/04839de96951539912661b54d6ea8653a3f610af/src/Input/Input.tsx#L95
Passing an argument to useUniqueId just uses whatever it's given (from userland) instead of generating one. I don't see your point, @stereobooster.
In that case maybe we could have ID fields as a separate component that extends Input, rather than having an isUniqueId prop on the Input component.
I like this. A new UniqueInput component or similar that's a thin wrapper around Input. 👌
