Tally Barak

Results 54 comments of Tally Barak

To start, styled components needs to be a singleton. Can you make sure styledComponents are defined as peerDependencies in your components? Explanation is here: https://docs.bit.dev/docs/react-guidelines#add-react-libraries-as-peer-dependencies-with-relaxed-versions

@qballer - you smile and the world smiles with you... gizmo does whatever you tell him to do.

It does not really fail - but an index file is created.

Do a create react app and make the logo.svg file into a component.

That will be great. In order for this to work with traditional component (read: not standalone), you will need to do something like Testbed which is the compilation context for...

Having an all repo config is probably not the best idea, as packages come in all shapes and forms. I think respecting the installation method provided during the npm install...

I want to make sure I understand it correctly: If I am doing `npm i ` from a machine that is configured with SSH, I will end up with git+ssh...

+1 as it collapses with Jasmine, used for E2E testing...

PAtch for stencil 3.0: ``` diff --git a/node_modules/@stencil/sass/.DS_Store b/node_modules/@stencil/sass/.DS_Store new file mode 100644 index 0000000..e69de29 diff --git a/node_modules/@stencil/sass/dist/index.js b/node_modules/@stencil/sass/dist/index.js index 42bda03..c989ed2 100644 --- a/node_modules/@stencil/sass/dist/index.js +++ b/node_modules/@stencil/sass/dist/index.js @@ -248,7 +248,8 @@...