TakeActionNow2019

Results 13 comments of TakeActionNow2019

At AT mode when using SQLServer, if any column of a table is with "IDENTITY", before inserting a value into this column, we should judge whether there is a "IDENTITY"...

May I know what is going on? How can I merge my pull request to the target branch?

> Can you shed some lights on why changing `targetBean` to `invocation.getTarget()` can sort it out? The latter can be subclass of the former, is that what you are tring...

> > > Can you shed some lights on why changing `targetBean` to `invocation.getTarget()` can sort it out? The latter can be subclass of the former, is that what you...

![image](https://github.com/apache/incubator-seata/assets/55011193/d1a0baeb-c106-405c-95d0-35709804a4ec)

> The third point, are you trying to express that when using @BusinessActionContextParameter in the interface and @TwoPhaseBusinessAction in the implementation class, it leads to the invalidation of @BusinessActionContextParameter? Nah....

What I did in the bugfix is to get the exact method annotated by @TwoPhaseBusinessAction and @BusinessActionContextParameter. (I suppose that it is a convention to put them together on a...

> > What I did in the bugfix is to get the exact method annotated by @TwoPhaseBusinessAction and @BusinessActionContextParameter. (I suppose that it is a convention to put them together...

> ![image](https://private-user-images.githubusercontent.com/19943636/324770174-88e6f0b2-17be-4555-a491-a430f5aadac9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4OTA5NTQsIm5iZiI6MTcxMzg5MDY1NCwicGF0aCI6Ii8xOTk0MzYzNi8zMjQ3NzAxNzQtODhlNmYwYjItMTdiZS00NTU1LWE0OTEtYTQzMGY1YWFkYWM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDIzVDE2NDQxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA5MDE0MGJkNTlhNDZiZTRlZGFhNjIyMDk5YzU2OGI4YjFmNjZiM2IyMGY2MjNiMDQyOTg3NmZjZDI3MTFhMDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vX_eXlAl1BZBnlC7Xgi9boQZ97z2QxxwLdqd5fhG0Xc) ![image](https://private-user-images.githubusercontent.com/19943636/324771635-9a17c625-fbdf-4207-8451-6f00bb23271d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM4OTA5NTQsIm5iZiI6MTcxMzg5MDY1NCwicGF0aCI6Ii8xOTk0MzYzNi8zMjQ3NzE2MzUtOWExN2M2MjUtZmJkZi00MjA3LTg0NTEtNmYwMGJiMjMyNzFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDIzVDE2NDQxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYzMjdjMDAzZDlmN2YzNjdkNmY1MGJkZWNkZDhhY2FlYThiM2ZjNGRhY2Y2NWNjZDI3YTc3NDlhYzg5MzFmMTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.DmHN-EUBpcv_seYGcZ0OGuEot67BR-FdDti1Qc5o_tY) > > It did not fix the issue where BusinessActionContextParameter is ineffective in interfaces I suppose it is a convetion to put @TwoPhaseBusinessAction and @BusinessActionContextParameter together. May...

@funky-eyes Please help me review it again! Thanks a lot!