ken

Results 66 comments of ken

> @TakaHiR07 Could you take a look at the check style issue? Thanks. have fix checkstyle.

> @TakaHiR07 Would you please help fix the failed tests? Thanks. @hangc0276 I have fix the test since powermock is removed in master branch.

> Normally, "Main" thread will wait for "component-shutdown-thread" thread to complete the "component start future". Your edition will cause future complete too soon, and main thread exit, which may cause...

> I think it's not an APIException, should we define this exception in https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ExitCode.java ? ExitCode looks like pointing out the exact reason why bookie start fail. It seems not...

Many failed test shows that in previous design, bookieServer start failed, but not throw exception. I think these test is also unreasonable and should be fixed. Looking forward to more...

since this is a fatal issue. Could you take a look of this analyse and fix? @shoothzj @dlg99 @merlimat @hangc0276

> First of all, this is a great catch and definitely looks like a regression. > > There are couple of things that require additional attention: > > First, the...

> I think we should fix the Timepoint4 behavior, it will handle all the pendindAddOps, and try to send the data to new replaced bookie. I think this behavior shouldn't...

> Thanks for your contribution. I have triggered the CI. BTW, how many bookies do you maintain? The largest cluster contains 400+ bookies. ![image](https://github.com/apache/bookkeeper/assets/13505225/92a8b0d1-9879-49e0-ac77-11107d197db0)

Have fixed the test. Can you trigger CI again, thx. @shoothzj @hangc0276 @jiazhai