Tait Hoyem
Tait Hoyem
I was hoping that you could have been more specific, since my intention was to gate a bunch of convenient macro behind a feature flag. I dug into acceeskit myself...
> Right now you have added strum as a required dependency, which is not good. Although I do sympathize with you wanting to keep accesskit's dependency tree small, I think...
> GetRoleName method of the org.a11y.atspi.Accessible interface. We don't implement it on AccessKit and I don't plan to do so as I think it is pointless. I might convince the...
Nice find, Luuk! Good to know.
You may be right, @DataTriny , but I think having an optional dependency makes sense here. `FromRepr`, and `IntoStaticStr` seem to be really useful abstractions. `Display` is whatever, since that...
After making `strum` optional, and gating all uses of it behind the feature "strum", it seems that Strum has become a bit more fundamental on this branch than before. It...
Yeah, I shouldn't merge with `main` but GH interface was complaining.
@DataTriny Curious if this would work for you? We've fully feature-gated `strum`, and still provided the vast majority of the implementations despite that. The only implementations that are not available...
@DataTriny right now, any use of `zbus` brings in the `TryFrom/TryInto` impls for each event. These require strum. Does accesskit use these implementations? If not, we can add a *separate*...
If you intend on using the `TryFrom/TryInto` implementations eventually, and they require `strum` does that mean that `acceskit` is ok to depend on strum? If not, does that mean that...