Tait Hoyem comments

Results 149 comments of


                                            Tait Hoyem

Rename `BusProperties::build` to `BusProperties::from_message` and auto implement conversion for most User Facing Event Types.

This sounds like a great plan! Should I do it? Or would you like to?

Rename `BusProperties::build` to `BusProperties::from_message` and auto implement conversion for most User Facing Event Types.

All good; I got a new keyboard this week, and I need to break it in!

Rename `BusProperties::build` to `BusProperties::from_message` and auto implement conversion for most User Facing Event Types.

I think that there are some other issues that are not possible to fix due to compiler limitations. Not being able to apply a blanket implementation for `TryFrom` is a...

Remove manual implementation of `Serialize`, `Deserialize`, and `From<u32>` for `-common` types

> Maybe TryFrom for Interface is not strictly needed? Yes. This is sort of the idea I'm getting at: ```rust pub enum Interface { #[serde(rename = ACCESSIBLE_INTERFACE_NAME)] Accessible, ... }...

Remove manual implementation of `Serialize`, `Deserialize`, and `From<u32>` for `-common` types

Thank you Luuk, for clarifying the issue and adding important information!

Exclude setting "async-std" and "tokio" features at the same time.

Yes... I think you're right about that. No, I don't think you can disable a festure when another is enabled.

Exclude setting "async-std" and "tokio" features at the same time.

I think this was changed when async-std and tokio were both allowed as features of zbus. And I said "oh good! now I don't have to worry about atspi having...

Avoid allocation in `Display` implementations

I can think of one case where this would be an issue: `AtspiError`. We use formatting to create the Display impl. Can you think of a way around this?

Update XML from upstream

Why did this branch before your CI fix? Strange.

Update XML from upstream

TODO: - [x] implement `Get/Set TextSelections` for `Document`. - [x] fix docs to look like Rust docs instead of DBus XML docs