Tomasz Misiukiewicz

Results 45 comments of Tomasz Misiukiewicz

Started code review and left some comments, gonna continue reviewing tomorrow :)

Just updated the code to handle Kotlin templates, tested it with freshly built app on 0.73 and seems to work well! ![image](https://github.com/react-native-community/cli/assets/13985840/1d6a24d3-0cca-4a49-b440-757e7ba11a0b)

did another round of review and tested it on both platforms, looks solid! 👍 some small conflicts need to be resolved before opening

@fabioh8010 when running `link-assets` without any linked assets and not having `assets` property in `react-native.config.js` file, there is no output from a command. Can we display a short instruction what...

@puneetlath I checked this list and seems like majority of these properties are generated in the runtime and describe the options for LHN, not reports directly. Seems like they are...

> This makes sense to me. Want to do this as a first step? Basically, raise a PR to update the type with only the things that are actually used...

So i verified all the properties and looks like there is 15 of them that should be possible to remove: - [x] `icons` - [x] `lastMessageTimestamp` - [x] `lastReadCreated` -...

Sure, i'll start with a PR with those that are not used anywhere as it's the easiest one