Will Smith comments

Results 42 comments of


                                            Will Smith

ARM64: Unable to decode `luti2` and `luti4` instructions

That makes sense. Thank you for looking at it. Will be looking forward to the LLVM 18 update.

Wrong expression is ignored warning range

I also expect the warning to show as @auduchinok described. The error does seem correct, but the range could be more accurate.

FS0026 "This rule will never be matched" not fired for combined match branches

This is a feature improvement to pattern matching by adding more warning checks. Be best to make a RFC on https://github.com/fsharp/fslang-design regarding it. There we should discuss it.

DefaultAugmentation on DU leads to badly generated type

@greatim Thank you for reporting this. I am having trouble reproducing your issue. I created two libraries like you said and the code generation appears to be correct; it's not...

Code Generation for Record.CompareTo(object, IComparer) lacks type-safety checks, and casts before checking nulls

I think this might be an improvement, it seems reasonable; but I don't know the full intentions of why we do a direct cast rather than check.

Generic struct type whose fields are all unmanaged types is unmanaged

This is actually quite easy to implement and it should not be a breaking change. We should make this change to follow C#.

Generic struct type whose fields are all unmanaged types is unmanaged

We would also need to interop with C# by looking at the `IsUnmanagedAttribute` on the type argument and be able to emit it as well.

Generic struct type whose fields are all unmanaged types is unmanaged

Yes and we would need to update docs as well.

Generic struct type whose fields are all unmanaged types is unmanaged

I have a PR for this: https://github.com/Microsoft/visualfsharp/pull/6064

Infinite loop on expanding cycle for struct types

@RikkiGibson had a test case for C#, and I tried in F# and we blew up :)