Tommaso Vaccari
Tommaso Vaccari
is this issue still open?
Someone knows why it's not passing benchmark test ?
> > Someone knows why it's not passing benchmark test ? > > You should check out some of the latest PRs in the repository . It has been a...
I need to review something about this PR or is it ok ?
> Can you write some tests for your PR. I've already added two test for this pull requests , if you have in mind something else let me know!
Thank you very much, @smichr . I would greatly appreciate it if you could explain why you imported those modules from the core. Additionally, I'm curious about how you made...
> I am not sure if it is a good idea to convert the input to Integer/Rational. Do you see an issue with doing so? In general, calculations with Python...
@oscarbenjamin so what do you suggest?
"We need to ensure that when inserting half-integer values, we use the `Rational` function, as opposed to Python's standard floating-point division (b = 1/2). This ensures accurate representation and proper...
The solution to the problem is to ensure that all input values provided to the Wigner3j function are represented using SymPy number types, such as Rational. Maybe we can work...