Szymon Kubica
Szymon Kubica
Hi, thank you for looking into the PR. Please don't worry about the timeline / delays, I realise that it is a non-trivial change and requires time to actually look...
Hi, Thank you for reviewing the PR and listing the required changes. I will start going through these and clarify in the comments above if anything turns out to be...
One note regarding your comment about asm_parser and disassembler being disabled: I have looked into those and I don't see anything which would prevent them from running under no_std. I...
Ok I did some restructuring and now the import switching is done the same way serde does it. I also changed some dependencies and now all modules build with both...
Re: signing off commits Yes I will do that from now on, I think some of my previous commits were already signed-off, but I noticed that the build doesn't go...
Ok @qmonnet I think the PR is in much better state now. Following your advice I have split my changes into two logical commits: - adding the `"std"` feature and...
Ok I think all of the comments have been addressed. Thank you very much for the feedback. Key changes introduced: - now examples are configured inside `Cargo.toml` and the ones...
Hi @qmonnet, I added a description of the `no_std` feature to the README, it was based on how `serde` explains their implementation of `no_std` support. This was done to resolve...
Ok I think all of the missing / redundant blank lines should be gone now. Sorry about these, I will pay closer attention to the diff from now on so...
> It could be interesting to add the following change as an additional commit to your PR: > > ```diff > diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml > index 60eefc28d727..a11391c430ca 100644 >...