Sergej Sakac

Results 144 comments of Sergej Sakac

> Needs tests + less duplciate code. Not quite sure what the new tests would be good for. Isn't this already tested in the ```bond_extra``` tests?

@kianenigma I forgot to add tests, but I have added them now, could you please review this?

@kianenigma Yes, my approach does add complexity to the code. Your approach seems simpler but still makes the code a bit more complex. And also if we implement this we...

@sudipghimire533 Note that you have to update the ```benchmarking.rs``` file also.

> Not working same error and neither can I assign it as variable and re-use. @kianenigma do you think you can help me with benchmarking.rs ? I have run into...

> > @sudipghimire533 The errors are now fixed :) > > Indeed, a smart wizard named Szegoo same and fixed everything.. Thanks a lot for helping out mate :) NP,...

> > > > @sudipghimire533 The errors are now fixed :) > > > > > > > > > Indeed, a smart wizard named Szegoo same and fixed everything.....

@sudipghimire533 Are you working on this, or may I finish this?