Sergej Sakac

Results 139 comments of Sergej Sakac

> How is max supply different from the concept of total supply? Total supply is something that changes when we call the mint function. Max supply is a constant that...

That could be an approach to this, but I believe that in some situations we don't want all of the max supply to be created. By setting a max supply...

@KiChjang In the previous comment I was just trying to note that there might be a situation where we might have a max supply without ever reaching it(e.g. creating an...

@kianenigma Actually as I made this PR I am not sure if this function fits in this pallet. It doesn't have anything to do with the offences or staking pallet,...

@bkchr Tests inside the utility pallet and node executor are the only places where `fill_block` is being used. Should we move this to the utility pallet, or did you have...

Ok, so should we first remove this to see if it is used(can't this cause some problems if `fill_block` is being used?) or should I add a new testing pallet...

> there should be other ways to achieve the same. @kianenigma Wouldn't this pollute the code in the tests though? Or do you have an idea which call would best...

> For example if we change `system::fill_block()` by some other function in system pallet (that's actually test-only and not in the Call enum), I don't think it would pollute anything....

@kianenigma I created the new pallet, There are two tests in the polkadot repository(one in kusama runtime and the other one in polkadot) I assume we should remove these tests(the...

@bkchr When compiling `kitchensink-runtime` I get the following error: ```the wasm32-unknown-unknown target is not supported by default, you may need to enable the "js" feature.```. I am not sure why...