Human-GEM icon indicating copy to clipboard operation
Human-GEM copied to clipboard

Feat: a task for checking the mass and charge balance should be included

Open feiranl opened this issue 2 years ago • 4 comments

As suggested in the #701, there should be a task check for the mass and charge balance should be added.

feiranl avatar Oct 09 '23 02:10 feiranl

@JHL-452b Could you address this?

feiranl avatar Oct 09 '23 02:10 feiranl

This shouldn't need to be coded from scratch.

There is a workflow that runs Memote tests: https://github.com/SysBioChalmers/Human-GEM/blob/ca9745dd74b64570575e26b845827b6bc9657fe9/.github/workflows/yaml-validation.yml#L28-L29

My suggestion would be to identify all the Memote tests that are needed, and call the corresponding functions from https://github.com/opencobra/memote/tree/c8bd3fe75e2d955deaec824d1e93ebe60e754710/tests/test_for_support

mihai-sysbio avatar Oct 09 '23 07:10 mihai-sysbio

My suggestion would be to identify all the Memote tests that are needed, and call the corresponding functions

it would be good and probably efficient to reuse existing code if possible

haowang-bioinfo avatar Oct 09 '23 07:10 haowang-bioinfo

the memote consistency check does include functions finding mass and charge unbalanced reactions

haowang-bioinfo avatar Oct 17 '23 20:10 haowang-bioinfo