Human-GEM icon indicating copy to clipboard operation
Human-GEM copied to clipboard

Many reactions have GPRs but not EC number. Is it possible to fill them in somehow?

Open johan-gson opened this issue 3 years ago • 8 comments

Description of the issue:

I'm currently working with GECKO3, and one of the ideas there is to work with the EC field in the model directly instead of identifying the EC. For Human-GEM, many reactions with GPRs have an empty EC field. Perhaps we could use getEnzymeCodes in GECKO2 to fill them in? Or has this been tried already?

I hereby confirm that I have:

  • [ ] Tested my code on my own computer for running the model
  • [ ] Done this analysis in the main branch of the repository
  • [X] Checked that a similar issue does not exist already

johan-gson avatar Sep 22 '22 10:09 johan-gson

sounds good. @IVANDOMENZAIN what do you think?

haowang-bioinfo avatar Sep 22 '22 11:09 haowang-bioinfo

I agree, this can easily be done

IVANDOMENZAIN avatar Sep 22 '22 11:09 IVANDOMENZAIN

Sounds good!

johan-gson avatar Sep 22 '22 11:09 johan-gson

I'm thinking we only replace the empty ones to stay on the safe side, right?

johan-gson avatar Sep 22 '22 11:09 johan-gson

Another interesting thing - it seems that some reactions also have EC numbers but no GPRS - I'm thinking that filling in the GPRs for those may be possible? If we don't have the GPRs, ftINIT cannot use them, and GECKO will also have problems, at least if we want to use dlkcat.

johan-gson avatar Sep 22 '22 12:09 johan-gson

I'm thinking we only replace the empty ones to stay on the safe side, right?

Yes, I agree

IVANDOMENZAIN avatar Sep 22 '22 13:09 IVANDOMENZAIN

filling in the GPRs for those may be possible?

To me this sounds like a lot more work, and likely much less automatic unless one would use a tool such as GPRuler (which may take hundreds of hours on the cluster to run). From what I noticed, there isn't a general issue for GPR curation in this repo. My suggestion would then be to restrict the current issue to fill in missing ECs with GECKO, and open a new one for GPR curation.

mihai-sysbio avatar Sep 24 '22 05:09 mihai-sysbio

@IVANDOMENZAIN Have you had time to look at this? I'm just thinking that for GECKO3 to work properly with Human-GEM, this needs to be fixed. It sounds like a quick thing to do, or did you run into trouble?

johan-gson avatar Dec 04 '22 23:12 johan-gson