GECKO icon indicating copy to clipboard operation
GECKO copied to clipboard

feat: specify carbon source with fermentation data

Open edkerk opened this issue 4 years ago • 2 comments
trafficstars

When generating multiple proteomics-constrained ec-models with different carbon sources, this currently would require different getModelParameters.m and fermentationData.txt files. Instead, in this PR:

  • the carbon source exchange reaction name is included in fermentationData.txt

  • load_Prot_Ferm_Data.m places this information in fermParameters.c_source

  • generate_ProtModels.m uses the condition specific fermParameters.c_source instead of the information from getModelParameters. (It does not replace parameters.c_source in getModelParameters, as the carbon source mentioned here is specific for each proteomics dataset)

  • some duplicated code (see line 25-27 and 37-39 in old file) was removed.

edkerk avatar Feb 05 '21 20:02 edkerk

Codecov Report

Merging #134 (6165161) into devel (cfb6b99) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #134   +/-   ##
=======================================
  Coverage   97.00%   97.00%           
=======================================
  Files           3        3           
  Lines         200      200           
  Branches       22       22           
=======================================
  Hits          194      194           
  Misses          4        4           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfb6b99...6165161. Read the comment docs.

codecov-io avatar Feb 06 '21 16:02 codecov-io

Last thing to fix here, although not just related to using different carbon sources, is that if generate_protModels runs for multiple conditions is overwrites the model file in every iteration, in location models/prot_constrained/NAME/NAME.xml. If can think of three solutions, of which I now implemented the first option (commit 2f51995):

  1. Rename the file in each iteration to models/prot_constrained/NAME/NAME_CONDITION.xml
  2. Alternatively save the file and the additional tables in models/prot_constrained/NAME_CONDITION/NAME.xml and comparable.
  3. Alternatively as 2, but only if the number of conditions > 1, otherwise save as models/prot_constrained/NAME/NAME.xml (as the original code).

(Also did a minor change of saveECmodel when toolbox 'RAVEN' is specified (commit 6165161), it now writes all model files in the same folder, same behaviour as COBRA),

edkerk avatar Feb 06 '21 16:02 edkerk

The changes intended here have been superseded by various developments as part of GECKO3.

edkerk avatar May 18 '23 15:05 edkerk