Alexandr Miloslavskiy

Results 94 comments of Alexandr Miloslavskiy

My understanding of the issue is that this is a race. If PowerShell doesn't "flush" output before `Stop-Transcript` is executed, the output gets lost. In my scripts, I think I'm...

This PR fixed the install problem for me, thanks!

There's no need to have win/aarch64 machine to build bundles, see https://github.com/eclipse-platform/eclipse.platform.swt/pull/413#issuecomment-1270658605 Without such machine, we won't be able to run tests against built binaries, but this is only a...

The new test looks quite weak to me, because `adrp x8, ???` is a rather common instruction which doesn't really identify the function we need for the dark theme. I...

It would be nice to also have code comments with Windows versions, like here: https://github.com/eclipse-platform/eclipse.platform.swt/blob/1a35d6e03a426a86924516c347fdba21c02db1e8/bundles/org.eclipse.swt/Eclipse%20SWT%20PI/win32/library/os_custom.c#L124-L138

^ this is just a suggestion, I will still approve without it.

@chirontt Just to clarify: * Before this PR, on your newest Windows, scrollbars are light * With this PR, on your newest Windows, scrollbars are dark once again is that...

@hmartinez82 to clarify, I'm waiting for you. @chirontt already got the version numbers, see above.

Please squash commits (because separating them does not convey any additional value here), you can use PR title as commit message. Then it can be merged.

> The code detection for Intel is doing exactly that This is not right, it checks a lot more: it checks that two instructions mention the SAME global variable. https://github.com/eclipse-platform/eclipse.platform.swt/blob/a39c32129cd733639e0ee68680b6ca974be1d645/bundles/org.eclipse.swt/Eclipse%20SWT%20PI/win32/library/os_custom.c#L227-L230