Brenno Lemos

Results 21 comments of Brenno Lemos

Coming late to this, but this is a great feature! However, this repository seems to be abandoned since April 2022 (correct me if I'm wrong, @davidpdrsn)... @briankung would you consider...

As of #2574, group drawers have been implemented and one of the demos on my video available on that PR is a power management menu. Although it works by mouse...

Apparently it fails CI because the new trait I added to `strum` is *obviously* not available on crates.io yet. Should I remove the doctest for the time being and introduce...

Hi there, @Peternator7 ! Can I get some feedback on this one? I could split the tests into a separate PR, which would likely make the CI pass ![image](https://github.com/Peternator7/strum/assets/25804378/19e62046-ac60-4530-9869-52ac29c5e9c4)

> What do you think about `VARIANTS` vs `ALL_VARIANTS`. It "conflicts" with the VariantNames derive, but that might be okay since type resolution should be able to figure out which...

Hi there, @Peternator7! Just wondering if you think anything else must be done to this PR or #315 in order to merge them?

Even with `try_` methods, it will still panic when no arguments are provided to messages expecting them ([here](https://github.com/XAMPPRocky/fluent-templates/blob/af69a9eaaac3191f254f24bd076dfb809eea8d79/src/loader/shared.rs#L32-L34)). This method should definitely return a `Result`, instead.

Hey guys! Coming in late but I'll try reproducing and taking a look at the code later today!

> I rebased the branch onto master and fixed the conflicts, but I didn't know what to do with the `extendOrphans` method. @Syndelis can you help out with this? What...

> As for something else, this PR currently removes the old persistent_workspaces config option. I'm thinking we should maybe still keep the old functionality as well? Otherwise lots of people's...