Swiftb0y
Swiftb0y
I'm sorry for being so rigorous with my review comments. Allow me to explain my reasoning: > I used existing code that is not nice but it is also not...
> I also have to say that there are too many ways to write javascript and I have to admit that i am not so familiar with the style used...
Yes, I'll try take a look later today.
> mixxx doesn't give enough time for shutdown to happen see this bug: https://bugs.launchpad.net/mixxx/+bug/1660488 I don't think that applies here. The bug report is about timers not running after the...
Does Qt have some abstraction that we can query whether the system is on a metered connection? We could use that for deciding the quality option and eagerness of the...
Thats pretty much exactly what I wanted, but yes, we can't use it because we're still stuck on Qt5.15
> So maybe we might use to fetch small for the first time and users can choose large to integrate. Yes, use the most appropriate size for the UI (depending...
Cover arts are usually only that big when their resolution is large (I'd estimate 11Mb to be about 5000x5000 pixels) or there is almost no compression... Rescaling/compressing the cover in...
We could also make the size of the cover art to be depended on the filesize. Then HQ flacs get HQ cover arts but LQ mp3s get low res cover...
> I do care about audio quality but I don't need 4k cover art : ) Thus I'd prefer a pref option. Right... still I think it would be a...