Swiftb0y
Swiftb0y
I agree that we need to roll our own solution here. But I'd like to have it split from the `EngineEffectDelay` for the sake of reuseability and separation-of-concern.
I think right now it would make most sense to address the currently unaddressed review comments from me. I recommend starting top to bottom in this PR thread.
> Yes, because of the memory fences, the compiler cannot use cashing between the cores optimal. I have no clue how big this penalty is though. According to [this great...
> Thank you for the nice result table from your system. I forgot to say that those actually came from CI, so the absolute values might not be really realistic....
IMO you can leave them as is for now. I just wanted to share some general thoughts on how we currently do our microbenchmarks. If you want to look into...
Hey @icedream. Thank you very much for sharing this. Since this PR seems to be abandoned, I don't know how useful it will be for the Prime 4 specifically, but...
Thats great. A very important usecase for mixxx would also be for laptop DJs that need to use other peoples (potentially the venues) gear. Since the SC5000/6000 seem to be...
You seem to have started your work on the main branch, please rebase on the 2.3 branch. https://github.com/mixxxdj/mixxx/wiki/Using%20Git#targeting-another-base-branch
@holopansel I'm sorry for forgetting about this PR and creating merge conflicts. Are you able to resolve them, I'll take a look at this PR asap then. Also, the new...
I don't know how proficient you are with git. The usual course of action is to merge 2.3 into your branch locally. Then git will complain that there are merge...