SwiftLintBot

Results 173 comments of SwiftLintBot

8 Warnings :warning: This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:620:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'instance_property' (type_contents_order) :warning: This...

1 Message :book: Skipping OSSCheck because SwiftLint hasn't changed compared to 'main' Generated by :no_entry_sign: Danger

17 Messages :book: Linting Aerial with this PR took 1.1s vs 1.11s on main (0% faster) :book: Linting Alamofire with this PR took 1.41s vs 1.42s on main (0% faster)...

1327 Warnings :warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:700:58: warning: Prefer Key Path Violation: Use a key path argument instead of a closure with property access (prefer_key_path) :warning:...

26 Warnings :warning: This PR introduced a violation in Firefox: /firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift:2447:81: warning: Prefer Type Checking Violation: Prefer a is X to a as? X != nil (prefer_type_checking) :warning: This PR...

2 Warnings :warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself! You can find it at CHANGELOG.md. :warning: This PR may need tests. 17...

1 Warning :warning: This PR may need tests. 18 Messages :book: Building this branch resulted in a binary size of 25119.02 KiB vs 25118.15 KiB when built on main (0%...

1 Warning :warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself! You can find it at CHANGELOG.md. 17 Messages :book: Linting Aerial with this...

17 Messages :book: Linting Aerial with this PR took 0.91s vs 0.92s on main (1% faster) :book: Linting Alamofire with this PR took 1.26s vs 1.27s on main (0% faster)...

659 Warnings :warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:161:5: warning: Cognitive Complexity Violation: Function should have cognitive complexity 15 or less; currently complexity is 17 (cognitive_complexity) :warning: This...