SwiftLintBot comments

Results 173 comments of


                                            SwiftLintBot

Restructure frameworks

1 Warning :warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself! You can find it at CHANGELOG.md. 17 Messages :book: Linting Aerial with this...

Activate strict concurrency checking in `swiftlint` module

1 Error :no_entry_sign: Could not build branch 2 Warnings :warning: Big PR :warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself! You can find...

Implement `allowed_types` option for `one-declaration-per-file` rule

1 Warning :warning: Big PR 18 Messages :book: Building this branch resulted in a binary size of 25523.99 KiB vs 25491.34 KiB when built on main (0% larger). :book: Linting...

Reverse Data -> String conversion rule

215 Warnings :warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:240:38: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion) :warning: This...

Fix superfluous disable command for `custom_rules`

17 Messages :book: Linting Aerial with this PR took 0.95s vs 0.93s on main (2% slower) :book: Linting Alamofire with this PR took 1.27s vs 1.28s on main (0% faster)...

Fix `--only-rule` config issues

17 Messages :book: Linting Aerial with this PR took 0.92s vs 0.92s on main (0% slower) :book: Linting Alamofire with this PR took 1.26s vs 1.27s on main (0% faster)...

Started to add rationales

1 Warning :warning: This PR may need tests. 18 Messages :book: Building this branch resulted in a binary size of 29581.29 KiB vs 29580.32 KiB when built on main (0%...

Fix only rule config issues

1 Warning :warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself! You can find it at CHANGELOG.md. 17 Messages :book: Linting Aerial with this...

SwiftUI: Prefer scaledToFit()/scaledToFill() over aspectRatio(contentMode:)

1 Warning :warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself! You can find it at CHANGELOG.md. 17 Messages :book: Linting Aerial with this...

Add syntax to swiftlint_version to allow for specifying minimum and maximum versions

1 Error :no_entry_sign: Could not build branch 1 Warning :warning: This PR may need tests. Generated by :no_entry_sign: Danger