Abhinav Pandey comments

Results 105 comments of


                                            Abhinav Pandey

gadgets/trace_ssl: Missing tests

Hello @836hardik-agrawal . Yes. I'm working on it. Although I was inactive for a few weeks as I was on vacation. If you want you can work on this too...

Remove Browndog

Only instances of Browndog remaining are below (w.r.t to `*.R` search)

Add function to Optionally get `site.info` if not present

@meetagrawal09 can you cross check if corresponding changes in `test.met.process` are valid or not? :)

Add function to Optionally get `site.info` if not present

Current code is updated for db-less interaction. What more improvements can be made? Would creating a new site-id be correct for a pre existing `lat` and `lon` or should we...

Add function to Optionally get `site.info` if not present

Should we add a unit test to check if `get.new.site()` works correctly?

Add function to Optionally get `site.info` if not present

Fixing the CI checks and test errors

Add function to Optionally get `site.info` if not present

Let's close this Pr once #3656 is merged

Reflected XSS on 03-inputs.php file

@robkooper

Idea: include rules in PromBench load

Hi @bboreham . I'd like to work on this issue for now. Can you explain some 'recording rules' which would be good to go as a beginning approach?

Remove assumption that $modeloutdir == $outdir / "out"

Wouldn't settings inherit the outdir value from the ~yml~ xml (edit) file? Am I on the right path here? If I'm correct and that's how settings work then we can...