Abhinav Pandey

Results 105 comments of Abhinav Pandey

> First, by "book" I assume we mean major subsections of the documentation, not distinct documents, as cross-referencing and maintaining the documentation is easier in the former Absolutely @mdietze. Similar...

I personally would favor usage of `log.Fatal` instead of consequent `log.Error` and `return` statements. It is because return statementstend to `return` while `log.Fatal` tends to stop the program. Imagine threading...

I've been brainstorming about our PR labeling and came up with some ideas to tweak our process. Thought I'd share them here : 1. **Refining Labels**: How about splitting 'Documentation'...

Here's how I want to proceed with the `labeler.yaml`: ```yaml 'Documentation/User': - book_source/** - documentation/user_guides/** 'Documentation/Developer': - CONTRIBUTING.md - DEBUGGING.md - DEV-INTRO.md # Introducing sub-categories under Models 'Models/Climate': - models/climate/**...

Insights @GandalfGwaihir ??

> I suspect the right labeling granularity would be something like individual models (Many people only use PEcAn with one model, so they'll pay attention to the `sipnet` label but...

Hey. Sorry for late response. I think the only changes that can be done should be - The Documentation splitting into `Dev-Docs` and `User-Docs` - Splitting `modules` and `models` into...

> it looks like maybe URLs that pass IDs as query parameters (e.g. http://localhost:8000/api/foo/?id=100) are working correctly, but those that include them as paths (e.g. http://localhost:8000/api/foo/100) are not. This seems...

Correct me if I'm wrong. In the auth section, I don't think we require authorisation to GET our models via : ```r res

I still think that the below test is useless since no timeout/endpoint has been set for such responses within our [test.inputs.R](https://github.com/PecanProject/pecan/blob/develop/apps/api/tests/test.inputs.R) ```r test_that("Calling /api/inputs/{input_id} with invalid parameters returns Status 404",...