CodeCop comments

Repositories
Issues
Comments

Results 4 comments of


                                            CodeCop

Unary operator misused, fails to compile with solidity v8.18

@stevieraykatz @NoahZinsmeister @danrobinson I have submitted a PR on this issue.

Solady ERC20 Does Not Grant Infinite Permit2 Allowance by Default

I have solved this issue at PR#150 : https://github.com/Uniswap/the-compact/pull/150

Should bytes calldata be replaced with bytes memory in IERC721 to prevent compilation errors?

- When you pass "" (an empty string) to a function expecting bytes memory, Solidity allows implicit conversion between string and bytes in memory. This means that "" (a string...

Should bytes calldata be replaced with bytes memory in IERC721 to prevent compilation errors?

> Hello @saniksin > > `IERC721` is just an interface. It is common to declare interface using `external` functions and calldata. When you call a contract by casting an address...