Sverre Winkelmans
Sverre Winkelmans
Ah, I missed that! I've changed the job to use the `IWorkflowInstanceManager`. Now It's similar to how it's done in the WorkflowInstance delete endpoint. I wonder if there is a...
@jayachandra21 I've updated it to be current with the main branch. I also moved the cloning of the `WorkflowInstanceFilter` to an extension method inside the module, so no code changes...
> > @jayachandra21 I've updated it to be current with the main branch. > > > > I also moved the cloning of the `WorkflowInstanceFilter` to an extension method inside...
Sounds good, I'll make the requested changes. Do you have in mind a contract for `IRetentionCleanupStrategy` Something along the lines of: ```csharp interface IRetentionCleanupStrategy { public Task Handle(IWorkflowInstanceFilter filter, CancellationToken...
This approach might work well. I will also check if this approach can be used if we would introduce a `RetentionPolicy` which would be a combination of a `IRetentionInstanceFilter` and...
If we allow a custom clean-up strategy which in the end does not enforce the deletion of workflow, we could have some scenarios that are not really retention focused. For...
@sfmskywalker, I've updated the module with the following usage: ```csharp elsa.UseRetention(retention => { retention.ConfigureCleanupOptions = options => { options.SweepInterval = TimeSpan.FromHours(4); options.PageSize = 25; }; retention.AddDeletePolicy("Delete completed workflows", sp =>...