Ben Kochie

Results 1558 comments of Ben Kochie

This should be possible here with a goroutine worker pool. We can parallellize the data collection. It doesn't look like the current collector records any timing information, even in debug...

@discordianfish Feel free to send a renaming PR.

Our standard base container, the busybox container, has a naming convention so we can select which arch output. For example: ```dockerfile ARG ARCH="amd64" ARG OS="linux" FROM quay.io/prometheus/busybox-${OS}-${ARCH}:latest ``` We use...

According to the docs, it can only set once per device. But, given that we loop over the devices, it does make sense that we allow setting it differently per...

Part of my refactoring for the flag controls was to allow for easier adjustment of flags to the various smartctl commands.

@josefzahner This is a community project, nobody gets paid to fix this. You're welcome to open a PR to improve things.

Someone needs to open a feature PR to extend the command line flags passed in various parts of the exporter.

What are the codespaces for? Can you add a bit of a "why" to the PR description?

Hmm, interesting idea. I think something like this should be discussed with the wider Prometheus dev community. It would be better to support this kind of thing consistently across all...

ENV vars are not very secure, as they can be leaked in a number of ways. It is more recommended to read credentials from a file, as these are more...