Ben Kochie
Ben Kochie
> I'd really rather avoid manually/explicitly parsing out the struct fields as it feels fragile and prone to breakage on procfs updates, so ideas welcome. This is actually quite intentional,...
Yea, let's just do the minimal migration and do any metric renaming as a separate task. Thanks!
Technically we have a major version stability guarantee around metric names. * Add a "use new names" feature flag. * Expose both the old and new names. But, it's just...
Maybe instead of exposing the sync percent, we should expose the "TODO" blocks value. This way the completion ratio can be correctly calculated as `node_md_blocks_synced / node_md_blocks_synced_todo`.
Released updated procfs: https://github.com/prometheus/procfs/releases/tag/v0.15.0
Unless I'm mistaken, it seems like the exporter is adding service discovery labels in the config file. This doesn't seem to follow best practices.
Great! This will need a sponsor from Prometheus Team.
This will need a Prometheus Team sponsor.
Yes, we would need a volunteer from Prometheus Team to sponsor support.
This will need a sponsoring maintainer from the Prometheus Team.