Ben Kochie

Results 1559 comments of Ben Kochie

@discordianfish Yes, the idea is to make the collector package more reusable as a library. I'm planning to do similar changes to other exporters.

@discordianfish We need one top-level config struct so that we can pass it all to `NewNodeCollector()`. We will need to create a number of `collector_common.go` files in order to contain...

@dswarbrick Usually the 1:1 issue is for the other way around, when there's more than one label per item, not missing labels.

Please test the latest release: https://github.com/prometheus/node_exporter/releases/tag/v1.6.1

@rexagod I think you're reading the stacktrace backwards. The error starts within `/usr/local/go/src/runtime/proc.go`. The exporter-toolkit is the end of the trace, basically the victim.

Unrelated, I do think this issue can be closed, we've had no more reports since 1.6.1.

The usual way to translate bitfields is to map each bit to a status string, and then have a series of bool values Something like ``` node_timex_status{status="STA_UNSYNC"} 1 ``` Since...

Sure, that works. Since this is a default enabled collector, perhaps we should still add a flag to either leave this off by default, or limit which status flags are...

@frittentheke Nobody has submitted an issue or PR to add it. But PromQL does not currently take hex value syntax, only decimal, as metric values must be float64. I think...

Note `container_memory_working_set_bytes` includes some kernel cache metrics. You want to look at `container_memory_rss` to find out how much Prometheus itself is using.