SungJin1212

Results 65 comments of SungJin1212

FYI. https://github.com/prometheus/prometheus/issues/15855

@yeya24 It needs to be reopened since many of the flaky tests remain.

It seems due to https://github.com/cortexproject/cortex/pull/6340/files#diff-f70ef13978fead446903645dc3a53f599c9986caef0ee88bd079e46f09231f53R81-R86, but your `distributor.shard-by-all-labels ` value is `true`. right? If you set it to `true` only for the `distributor` and `querier`, other components would fail at...

@yeya24 Thanks for letting me know. Should we make the issue to track it?

@alanprot I added a comment here: https://github.com/cortexproject/cortex/issues/6324

@yeya24 Thanks. I read it, and it would be good if we could reuse its functions!

@yeya24 I added `-distributor.remote-write2-enabled` flags to configure whether the Distributor can accept PRW2.0. I added the `TestIngesterRollingUpdate` e2e test, where the Distributor can accept PRW2.0 and the Ingester uses the...

@yeya24 Yes, the test condition is that Ingester uses a v1.18.1 image and Distributor uses a PRW2.0-implemented one. The PRW2.0 push then gets that result. If the Ingester and Distributor...

@yeya24 Should I add comments to `-distributor.remote-write2-enabled` so that the user can do a rolling update of the Ingesters first and then update the Distributor afterward?