Jakub Łabor
Jakub Łabor
This PR looks amazing and is super helpful! I was looking into implementing something similar and would like to throw a suggestion up for discussion, Would it be possible to...
This sounds like a great initiative and is a big step forward for display standards in SUI! I would like to structure my feedback in two, how this structure affects...
Thanks for the info @amnn, good to hear it's getting fixed!
Thanks for the review @jakobhellermann @james7132! I made the following changes to address your review comments: - `init_dynamic_info` now caches dynamic bundles and only verifies component existence when creating new...
Now that I think about it `init_dynamic_info` is quite cheap to call so I could get away with creating API that doesn't expose `BundleId`.
Worked like a charm, only `insert_by_id` and `insert_bundle_by_id` are retained as public APIs. The only drawback is I had to cache the storage types of bundle components, this seems relatively...
Rebased PR Renamed `insert_bundle_by_id` to `insert_by_ids`
We've been using this pattern to authorize getting a mutable reference to an object from a type-erased container which should only be allowed in the context of the module defining...