Sturle Nesvik Spetland

Results 22 comments of Sturle Nesvik Spetland

Looks good to me now. @augustjohnson could you verify?

> @property > def size_id(self): > # Convert the size to lowercase for case-insensitive comparison > lowercase_size = self.size.lower() > > # Return the size_rating based on the mapping or...

This is because the API lacking any awareness for what "size" classification means in D&D and is just sorting alphabetically. A possible solution is to add a new numeric field...

> And if we're doing a bulk export, why not do that at build-time? I've been experimenting with this. I create separate json files for each creature during build and...

> new attribute: side_id I like the idea of this, but I think it deserves it's own separate PR or be merged with #401. Splitting content and API changes will...

I think they could be separated into a generic id `item-obsidian-greatsword` and a unique id `item-obsidian-greatsword-wotc-dndnext`, where the generic id could refer to different items based on your ruleset and...

> * Due to the nature of our server, caches never need to expire and everything is safe to cache. This isn't necessarily true due to errata. No expiration would...

For this situation I'd say a CDN is superior since it avoids using any server resources. It will have to be set at the DNS level though.

From what I can see, Cloudflare caching is not currently enabled on the API. Here's a comparison between fetching all monsters from api.open5e.com and my own mirror. The mirror has...

Using the mod [Immersive Speechcraft](https://www.nexusmods.com/skyrimspecialedition/mods/21296), you can gift items to other players. Because of this, I believe adding the ability give items through this mod should be doable, just depends...