Xiangxi Guo (Ryan)
Xiangxi Guo (Ryan)
Thanks for sharing. So basically there's no way of supporting my example use cases right now?
The more I think about it, the more I believe the alternative approach is preferable. Especially true for cases like this: ```solidity contract Immutable { uint256 public immutable iamImmutable; constructor(bool...
> I fear that the complete solution is a bit more complicated Would you mind elaborating on what edge case I might be missing? Based on my limited understanding of...
@chriseth @Marenz I updated using the alternative approach. The extra check in `ImmutableValidator::checkAllVariablesInitialized` should make the high-level logic pretty clear. Regarding proper detection of "multiple writes to a variable in...
> I didn't find any code logic errors, mostly style. Oh, a changelog entry is also missing. Other than that, looks good to me. Thanks! 1. All comments are addressed...
1. Addressed all comments. 2. Added comments to help clarify code logic. 3. Rebase.
> @StrongerXi would you like to address the open comments or should we take the PR over from here? My apologies. Got very busy during the last few weeks. Will...
> Does this need updated documentation? I already updated the documentation in the header.