Kevin Leung

Interesting. Specifically, you're referring to the definition here https://github.com/ggtracker/sc2reader/blob/c2a5407cb13fc41e2b44af07ae2a7ba48ffb7695/sc2reader/events/game.py#L330 and corresponding effort to populate it here https://github.com/ggtracker/sc2reader/blob/c2a5407cb13fc41e2b44af07ae2a7ba48ffb7695/sc2reader/engine/plugins/context.py#L72 and here https://github.com/ggtracker/sc2reader/blob/c2a5407cb13fc41e2b44af07ae2a7ba48ffb7695/sc2reader/engine/plugins/context.py#L86 Right? Given that there are references to `target` in other...

@eudaimonstro Sorry for the slow reply. I forgot to deploy v1.6.0 that fixed parsing for StarCraft 2 5.0 replays. v1.5.0, which is what I suspect you had, did not work...

> hi, did u solve this problem? I got this too ......................... Are you also using alphastar replays? Can you link tot he replay you're using?

I think the idea was to connect to the data available at https://develop.battle.net/documentation/starcraft-2/community-apis Of course, it's hard to say because we never got there, and this issue is 5 years...

Hmm, the short answer is I don't know. The last time this came up was https://github.com/ggtracker/sc2reader/pull/154 And I seem to remember vaguely that Blizzard made other changes in the past...

Right, so I think the comment linking points to a general issue that the sc2reader library assumes that these replays were generated off of actually played games. Those games have...

Solid analysis. To the extent that users haven't been missing this data so far, I'm inclined to put this at `load_level` 1, with the caveat that the player data only...

Cool project idea! I think ideally, this question should be in the https://github.com/ggtracker/sc2reader/discussions since it doesn't pertain directly to changes in the codebase, but happy to respond here first There's...

THis is addressed in #187

It looks like this change would require that we change `"snapshots"` on this line https://github.com/syrusakbary/snapshottest/blob/fe2fd80bfd2ae36adcae89fd4f57a563ffb68003/snapshottest/module.py#L187 into something configurable. I didn't quite get your reference to `setup.cfg`, though, and more generally,...