Kevin Leung

Results 90 comments of Kevin Leung

Is it all events in this replay that have the player set to none, or is it only specific events that are missing the player? If it's the latter, can...

Oh, that is fascinating. I have to admit that despite being the current maintainer for this library, I am completely unfamiliar with this code =P Since you have a reasonable...

Thanks for bringing this up. I looked through the code, and we actually have 16 hardcoded in a lot of places that would be difficult to pass the appropriate context...

There was a short discussion on #66 about whether we should test all python 3.x versions. Given the rate at which the core library changes, I don't see compatibility being...

I'm onboard with dropping python 2 support since no one has voiced opposition to it. Probably the first step is to remove references to it in setup.py etc, then run...

I think this is the latest API offered by blizzard https://develop.battle.net

That could be helpful! Is your `TimeSeries` in a public branch somewhere that you can link?

Interesting approach! I'll just say to leave this issue open for comment if anyone else comes across it and thinks it would be useful.

@aaliyah-art can you verify if #104 fixes your issue? I will merge if so

Issue re-opened. Makes sense to add the test case but only if we actually have a fix for it. And that test and fix should be in the same PR....