Steve Coffman

Results 340 comments of Steve Coffman

What version of gqlgen are you using? PR would be welcome, or a public github repository that reproduces the issue.

Several folks have reported everything works fine. I don't have a specific migration guide, so while you do this, can you keep notes for other folks to follow in your...

@Melkeydev Just checking in, but are you able to merge this PR now after it addressed the feedback?

@michelepra There are _a lot_ of test failures and lint errors. I think adding a disabled by default config option would avoid fix these, and avoid breaking backwards compatibility for...

@atzedus Do you have any thoughts on this?

@DPJacques Have you considered a way to correct this behavior on newer Go versions?

@tomoikey I'm really sorry for the delay in providing you with a review! While I'm thrilled with the performance improvement, I hesitate to merge this as is, but I really...

@tomoikey Since your #3874 PR has now been applied, I was wondering how much of this original PR could be simplified?

This would be a useful PR if you are interested in contributing it!

Thanks, this is helpful for many people, but I think people will want to opt-in with a configuration option, as some people may want their comments to be more succinct...