Steve Coffman comments

Results 340 comments of


                                            Steve Coffman

[BUG] Upgrading to v2 buf generates an import statement for JavaScript/Typescript that doesn't exist.

Hi! Connect-ES no longer needs its own code generator plugin, so I think you can close this issue, right?

`@defer` support with `accept: multipart/mixed` header rather than `accept: text/event-stream`

Yeah, I kind of prefer the first option based on what the Apollo code looks like. I love a PR!

`@defer` support with `accept: multipart/mixed` header rather than `accept: text/event-stream`

@giulio-opal Also, I'm curious what you (or anyone) use as an alternative to Apollo Router? At work, we built our own closed-source GraphQL gateway but it still uses the Apollo...

`@defer` support with `accept: multipart/mixed` header rather than `accept: text/event-stream`

@giulio-opal Do you think that this issue can be closed? I was waiting to see if you had any remaining work in follow-up PRs before cutting a release.

Bug with `struct_fields_always_pointers` config

Thanks, if you are able to figure out why this is happening and have a PR I'm happy to look at it.

Add websocket shutdown grace period

@john-markham Hey, I'm just curious what the status of this is. There was a flurry of other websocket activity, and I got confused where this PR fits with all that.

Enum values are now checked in json.Unmarshal

Sure. I'm always happy to merge to PRs to opt out of behavior like this, especially if you leave the code better than you found it. This project is maintained...

chore(deps): bump github.com/matryer/moq from 0.4.0 to 0.5.3

@dependabot recreate

fix op to rc in comment of FieldContext.Child

Hey, I appreciate making things more consistent, but it feels unintuitive for the `graphql.GetOperationContext(ctx)` to be assigned to `rc`. If we have a mix, I would rather find the places...

fix op to rc in comment of FieldContext.Child

Thanks so much! This has confused a number of people, so I appreciate you cleaning it up! Looking forward to future contributions from you!