Steven Engelbert

Results 142 comments of Steven Engelbert

https://github.com/user-attachments/assets/5784bc4e-b71b-4807-a947-2f6f587e699f Log persistence has been moved to the updater page (now called admin) and plugged in properly See video for changes and proof of function, or go to lamplipi now...

> Next steps are make sure you can actually access persisted logs from the logs page, and find where those are stored in the first place I've found the file...

Revoking reviews requested and marking as draft, I've found more bugs in this PR due to working on a PR based on this one (I'm building out the admin settings...

> I like the certainty of something that will turn off after some time but I also get the need/want for full control. This really should only be a temporary...

> I've elected to shoot for a middleground where there's a "persist logs auto-deactivate delay" that can be set right alongside the persist logs status This took some working and...

![image](https://github.com/user-attachments/assets/d922777c-f76f-4339-af68-42ca65ada0e4)

![image](https://github.com/user-attachments/assets/78cb5c3d-6526-45cf-884b-10d1f6a291a4)

> Here's a couple of things that could make the log persistence config more cohesive > > * Move the warning underneath the checkbox and make it grey? > *...

> imo, this doesn't close out [System log persistence during important events #741](https://github.com/micro-nova/AmpliPi/issues/741) unless this logging is turned on before/during important events https://github.com/micro-nova/AmpliPi/issues/741#issuecomment-2243223153 Was this not your preferred solution after...

There is now a notification of success or failure Admittedly it's not terribly useful as it doesn't tell you what happened, but it's easy and non-intrusive. It also comes up...